Playing devil's advocate: I would suggest the general population of women are not going to answer honestly to the question of what they find attractive. There is too much societal pressure to give certain answers (confidence, honesty, good job etc.). While those traits undoubtedly help, but you'll find empirically that simply confident honest men with good jobs often find themselves having mediocre success with women. Rather, it may make more sense to observe how women behave, to find an appropriate answer to this age-old question.
The reason for this is that a majority of attraction is subconscious. It occurs as a result of evolutionary and societal cues that indicate health, strength, virility, fertility etc. (traits that were essential to survival and ultimate success in the bad old days). The importance of these traits has undoubtedly been exaggerated by Hollywood.
Now that is not to say it isnt worth cultivating skills, passions, emotions, character, and charm. Those are positives for anyone in dating and in life. It is, however, important to show empathy to those who have worked tirelessly their whole lives cultivating what women say they want, and still being hopeless due to something nobody has talked about (craniofacial/dermal disfigurement for example). We must acknowlege the struggle some people face, and search for real applicable solutions for them. Telling someone with disfiguring acne to take a shower, get a haircut and be confident is not helpful.
